fix(pilotctl): surface app store + missing commands in help and context#332
Merged
Conversation
pilotctl help (usage), the JSON `context` catalog, and per-command --help had drifted from the dispatch table: - usage() listed set-tags/clear-tags/gateway as core commands, but they are extras-gated and error out when invoked that way. - usage() and context omitted the entire `appstore` family plus review, verify, recovery, prefer-direct, trusted, and the extras tier. - verify/recovery/prefer-direct/quickstart had no per-command help. Realign all three surfaces with the actual commands: - usage(): drop the extras-gated entries from core; add App Store, Updates, and Identity & recovery sections, trusted/prefer-direct, and an operator/admin pointer to `pilotctl extras` / `pilotctl context`. - context: bump to v1.4, add an `app_store` section (15 subcommands) and core entries for quickstart/update/updates/skills/review/verify/ recovery/prefer-direct/trusted. - commandHelp: add entries for verify/recovery/prefer-direct/quickstart. go build, go vet, and go test ./cmd/pilotctl all pass.
IPCServer.Start flipped the process-global syscall.Umask around net.Listen to create the socket at 0600. umask is process-wide rather than goroutine-scoped, so under parallel tests a concurrent t.TempDir() inherited the restrictive 0177 mask and its nested mkdir failed with "permission denied", flaking the pkg/daemon suite on both runners. Bind the socket inside a freshly-created private 0700 staging dir, chmod it 0600, then atomically rename it onto the published path. This closes the same TOCTOU window without ever touching the global umask.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return fmt.Errorf("chmod socket %s: %w", s.socketPath, err) | ||
| } | ||
| if err := os.Rename(stagePath, s.socketPath); err != nil { | ||
| ln.Close() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
pilotctlhelp drifted from the actual command dispatch table. Three surfaces were out of sync:usage()(barepilotctl/-h/--help) listedset-tags,clear-tags, andgatewayas core commands — but they areextras-gated and error out when invoked that way (error: set-tags is not in the core CLI).usage()andpilotctl contextomitted the entireappstorefamily (15 subcommands) plusreview,verify,recovery,prefer-direct,trusted, and any pointer to theextrastier. The MOTD tells users to runpilotctl appstore catalogue, yet--helpnever mentionedappstore.verify,recovery,prefer-direct,quickstarthad no per-command--help(fell back to "No specific help").Changes
usage()— remove the extras-gated entries from the core listing; add App Store, Updates, and Identity & recovery sections; addtrustedandprefer-direct; add an operator/admin pointer topilotctl extras/pilotctl context. Gateway/tags now shown aspilotctl extras ….contextCatalog()— bump schema to v1.4; add a top-levelapp_storesection (all 15 subcommands) and core entries forquickstart,update,updates,skills,review,verify,recovery,prefer-direct,trusted.commandHelp— add entries forverify,recovery,prefer-direct,quickstart.No behavior changes — help/discovery text only.
Verification
gofmt,go vet ./cmd/pilotctl,go build ./cmd/pilotctl,go test ./cmd/pilotctl— all pass.--helpnow lists the app store + all first-class commands and no longer showsset-tags/gatewayas core;pilotctl contextreportsversion 1.4with theapp_storeblock;pilotctl verify|recovery|prefer-direct|quickstart --helpall resolve.